Fix the return value in case of a parse error#233
Merged
robocoder merged 1 commit intoleafo:masterfrom Jan 27, 2015
bgarret:patch-1
Merged
Fix the return value in case of a parse error#233robocoder merged 1 commit intoleafo:masterfrom bgarret:patch-1
robocoder merged 1 commit intoleafo:masterfrom
bgarret:patch-1
Conversation
Collaborator
|
Could you instead move the |
Without the return, the server renders a 304 Not Modified if there's an error
Contributor
Author
|
You're right, it's cleaner this way. The change is done, let me know if you need anything else. |
robocoder
added a commit
that referenced
this pull request
Jan 27, 2015
Fix the return value in case of a parse error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the return, the server renders a 304 Not Modified if there's an error